[Metricbeat] Migrate Ceph osd_tree to use ReporterV2 interface #11048
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
sayden
added
Metricbeat
|
jenkins, test this please |
| @@ -36,6 +36,8 @@ var ( | |||
| }.Build() | |||
| ) | |||
|
|
|||
| var logger = logp.NewLogger("ceph.osd_tree") | |||
There was a problem hiding this comment.
If you rebase to master, you can remove this line
| content, err := m.HTTP.FetchContent() | ||
| if err != nil { | ||
| return nil, err | ||
| logger.Error(err) |
There was a problem hiding this comment.
If you rebase to master, you can use m.Logger().Error(err) here instead
| } | ||
|
|
||
| events, err := eventsMapping(content) | ||
| if err != nil { | ||
| return nil, err | ||
| logger.Error(err) |
There was a problem hiding this comment.
If you rebase to master, you can use m.Logger().Error(err) here instead
| err := mbtest.WriteEvents(f, t) | ||
| if err != nil { | ||
| f := mbtest.NewReportingMetricSetV2(t, getConfig()) | ||
| events, errs := mbtest.ReportingFetchV2(f) |
There was a problem hiding this comment.
Again, this is the only critical change needed here. Check my comments here to avoid a flaky test
berfinsari
force-pushed
the
migration/mb/reportv2/ceph/osd_tree
branch
from
388b053
to
65c4dbb
Compare
|
Thanks for your review. I believe I've addressed all the feedback now. |
|
jenkins, test this |
Refer to #10774 for more info