-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a issue when cancelling an enroll. #11067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Mar 5, 2019
Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: elastic#10150
ph
force-pushed
the
fix/confirm-no-enroll
branch
from
March 5, 2019 18:58
c27fbab
to
b7b58bb
Compare
reviews changes are in and I've rebased. |
kvch
approved these changes
Mar 6, 2019
jenkins test this please Just to make sure that jenkins is fine with that. |
Merged
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 11, 2019
Missing changelog for elastic#11067
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 11, 2019
Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: elastic#10150 (cherry picked from commit 5eb5085)
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 11, 2019
Missing changelog for elastic#11067
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 13, 2019
Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: elastic#10150 (cherry picked from commit 5eb5085)
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 13, 2019
Missing changelog for elastic#11067
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 13, 2019
Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: elastic#10150 (cherry picked from commit 5eb5085)
ph
added a commit
to ph/beats
that referenced
this pull request
Mar 13, 2019
Missing changelog for elastic#11067
ph
added a commit
that referenced
this pull request
Mar 13, 2019
…1186) * Fix a issue when cancelling an enroll. (#11067) Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: #10150 (cherry picked from commit 5eb5085)
ph
added a commit
that referenced
this pull request
Mar 14, 2019
…1185) Cherry-pick of PR #11067 to 7.0 branch. Original message: Fix an issue with a partial enroll, when a user refused to overrides a local configuration actually the enroll command did already used the token on the ES cluster, this commit move the confirm in the CM instead of having it in the Enroll's function and is executed by sending the token or creating any files on disk. Fixes: #10150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with a partial enroll, when a user refused to overrides a
local configuration actually the enroll command did already used the
token on the ES cluster, this commit move the confirm in the CM instead
of having it in the Enroll's function and is executed by sending the
token or creating any files on disk.
Fixes: #10150