[Metricbeat] K8s apiserver metricset to new data generation #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the kubernetes/apiserver to the new testing methodology. I kept the old tests around for now but they should be removed as soon as we agree the output of this change is as we expected.
ruflin
added
module
review
Metricbeat
10 tasks
|
To be on the save side, I suggest for now we keep the old tests around and clean up later. Ready for review. |
sayden
suggested changes
Mar 7, 2019
|
@sayden The rabbitmq file must be here as otherwise the build would go red. The reason is the introduced sorting which also modified the rabbitmq golden files. |
sayden
approved these changes
Mar 7, 2019
|
Thanks for the explanation @ruflin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the kubernetes/apiserver to the new testing methodology. I kept the old tests around for now but they should be removed as soon as we agree the output of this change is as we expected.
For the test data I think we should add some smaller examples that test specific things like grouping correctly.