[Heartbeat] Fix status for TCP checks (Master) #11118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'. This patch fixes that and adds tests.
andrewvc
force-pushed
the
fix-tcp-updown-7
branch
from
adbb767
to
cc9e1e2
Compare
ruflin
approved these changes
Mar 7, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 7, 2019
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'. This patch fixes that and adds tests. (cherry picked from commit e5c3485)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Mar 7, 2019
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'. This patch fixes that and adds tests. (cherry picked from commit e5c3485)
andrewvc
added a commit
that referenced
this pull request
Mar 8, 2019
…ter) (#11140) * [Heartbeat] Fix status for TCP checks (#11118) The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'. This patch fixes that and adds tests. (cherry picked from commit e5c3485) * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #10777 to the master branch (which can then be backported to 7.x and 7.0). I opened this concurrently to get it in sooner.
The heartbeat checks for TCP send/receive have been broken for a long time, since at least 6.3 from my testing. An error was returned, but the status was still set to 'up'.