-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Make integration tests more generic for modules #11131
Conversation
The goal is that each module on its own has less and less code and is more config based. The basic fetch testing we have for each module is moved into a general integration testing and it uses the configuration to figure out which services to start, ports to talk to etc. This is still WIP and needs quite a bit of cleanup.
I would like to get #7957 first merged before moving forward with this as I think it will look even simpler with it (and otherwise conflicts with it). |
I really like this idea. |
@jsoriano As discussed, assigning to you. |
@jsoriano It would be really nice to have this "unified" but as it went stale for quite some time I suggest I close it for now. Please reopen if you still plan to work on it. |
This (or something similar) was implemented in #11981. |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @ruflin? 🙏
NOTE: |
The goal is that each module on its own has less and less code and is more config based. The basic fetch testing we have for each module is moved into a general integration testing and it uses the configuration to figure out which services to start, ports to talk to etc.
This is still WIP and needs quite a bit of cleanup.