Add sleep to allow ES sufficient time for CCR #11172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
module
review
Metricbeat
ruflin
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
LGTM, especially as the build is green.
In general not a big fan of time based timeouts as in the past this often has lead to flaky tests on it's own. Instead, could we instead have a "wait for" approach that checks the api every 100ms for a max of 5s and then returns an error?
I'm good with merging as is as it already adresses an issue but would be good to have long term a nicer solution.
cachedout
approved these changes
Mar 11, 2019
|
@ruflin Agreed that waitFor is better than sleep. Will implement in this PR. |
ruflin
approved these changes
Mar 13, 2019
|
@ycombinator Already merged so today we can see if it has an effect on new PR's. |
|
Thanks @ruflin! |
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Jun 5, 2019
After repeatedly running the Elasticsearch module integration test in Metricbeat, I found that sometimes Elasticsearch doesn't get enough time to perform CCR and generate CCR stats. This causes the following error, but only some times:
```
--- FAIL: TestFetch (2.44s)
--- FAIL: TestFetch/ccr (0.08s)
elasticsearch_integration_test.go:92:
Error Trace: elasticsearch_integration_test.go:92
Error: Should NOT be empty, but was []
Test: TestFetch/ccr
```
So this PR adds a 300ms sleep to give Elasticsearch enough time to perform CCR and generate CCR stats. After testing various sleep durations, I found that 300ms seemed to be the lowest (round) value I could use that consistently passed this test.
Possibly related: elastic#10866
ycombinator
added a commit
that referenced
this pull request
Jun 6, 2019
* Add sleep to allow ES sufficient time for CCR (#11172) After repeatedly running the Elasticsearch module integration test in Metricbeat, I found that sometimes Elasticsearch doesn't get enough time to perform CCR and generate CCR stats. This causes the following error, but only some times: ``` --- FAIL: TestFetch (2.44s) --- FAIL: TestFetch/ccr (0.08s) elasticsearch_integration_test.go:92: Error Trace: elasticsearch_integration_test.go:92 Error: Should NOT be empty, but was [] Test: TestFetch/ccr ``` So this PR adds a 300ms sleep to give Elasticsearch enough time to perform CCR and generate CCR stats. After testing various sleep durations, I found that 300ms seemed to be the lowest (round) value I could use that consistently passed this test. Possibly related: #10866 * Fixing formatting
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#12437) * Add sleep to allow ES sufficient time for CCR (elastic#11172) After repeatedly running the Elasticsearch module integration test in Metricbeat, I found that sometimes Elasticsearch doesn't get enough time to perform CCR and generate CCR stats. This causes the following error, but only some times: ``` --- FAIL: TestFetch (2.44s) --- FAIL: TestFetch/ccr (0.08s) elasticsearch_integration_test.go:92: Error Trace: elasticsearch_integration_test.go:92 Error: Should NOT be empty, but was [] Test: TestFetch/ccr ``` So this PR adds a 300ms sleep to give Elasticsearch enough time to perform CCR and generate CCR stats. After testing various sleep durations, I found that 300ms seemed to be the lowest (round) value I could use that consistently passed this test. Possibly related: elastic#10866 * Fixing formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After repeatedly running the Elasticsearch module integration test in Metricbeat, I found that sometimes Elasticsearch doesn't get enough time to perform CCR and generate CCR stats. This causes the following error, but only some times:
So this PR adds a 300ms sleep to give Elasticsearch enough time to perform CCR and generate CCR stats. After testing various sleep durations, I found that 300ms seemed to be the lowest (round) value I could use that consistently passed this test.
Possibly related: #10866