Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws sqs overview dashboard #11175

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Add aws sqs overview dashboard #11175

merged 3 commits into from
Mar 15, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 11, 2019 •
edited
Loading

This PR is to add an overview dashboard for SQS.
sqs_dashboard

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 11, 2019 05:45
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 11, 2019
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. Team:Integrations Label for the Integrations team [zube]: In Progress review and removed [zube]: In Progress in progress Pull request is currently in progress. labels Mar 11, 2019
@kaiyan-sheng
Copy link
Contributor Author

Even though I wrote a script to write data into sqs, it still looks very boring...

ruflin
ruflin approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any chance you could also add the script you used to the metricset so we have it for the future?

@kaiyan-sheng
Copy link
Contributor Author

LGTM.

Any chance you could also add the script you used to the metricset so we have it for the future?

https://github.com/kaiyan-sheng/aws-go-scripts I put the script here. It's private right now. If you think it's ok/useful, I can make it public later 👍

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 15, 2019 18:35
@kaiyan-sheng
Copy link
Contributor Author

jenkins, test this please

@kaiyan-sheng kaiyan-sheng merged commit 6b915a5 into elastic:master Mar 15, 2019
@kaiyan-sheng kaiyan-sheng deleted the sqs_dashboard branch March 15, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @ruflin