Always send _type to Monitoring Bulk API #11217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Monitoring Bulk API (POST _xpack/monitoring/_bulk) does not interpret _type in the bulk metadata the same was as the regular Bulk API (POST _bulk). In the case of the Monitoring Bulk API, _type has a special meaning. It does not correspond to the Elasticsearch document _type but rather a type field within monitoring documents. The _type of those monitoring documents gets automatically set to _doc by the Monitoring Bulk API. Therefore, the Beats monitoring code should always send _type to the Monitoring Bulk API.
ycombinator
added
review
libbeat
needs_backport
|
Pinging @elastic/stack-monitoring |
|
LGTM (I think) I am not familiar with this code, but as long it continues to send the The description for the issue is correct such that |
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
urso
approved these changes
Mar 13, 2019
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Mar 13, 2019
The Monitoring Bulk API (`POST _xpack/monitoring/_bulk`) does not interpret `_type` in the bulk metadata the same was as the regular Bulk API (`POST _bulk`). In the case of the Monitoring Bulk API, `_type` has a special meaning. It does not correspond to the Elasticsearch document `_type` but rather a `type` field within monitoring documents. The `_type` of those monitoring documents gets automatically set to `_doc` by the Monitoring Bulk API. Therefore, the Beats monitoring code should always send `_type` to the Monitoring Bulk API. (cherry picked from commit ac72b5c)
ruflin
removed
the
needs_backport
ycombinator
added a commit
to ycombinator/beats
that referenced
this pull request
Mar 13, 2019
The Monitoring Bulk API (`POST _xpack/monitoring/_bulk`) does not interpret `_type` in the bulk metadata the same was as the regular Bulk API (`POST _bulk`). In the case of the Monitoring Bulk API, `_type` has a special meaning. It does not correspond to the Elasticsearch document `_type` but rather a `type` field within monitoring documents. The `_type` of those monitoring documents gets automatically set to `_doc` by the Monitoring Bulk API. Therefore, the Beats monitoring code should always send `_type` to the Monitoring Bulk API. (cherry picked from commit ac72b5c)
ycombinator
added a commit
that referenced
this pull request
Mar 13, 2019
…11229) Cherry-pick of PR #11217 to 6.7 branch. Original message: The Monitoring Bulk API (`POST _xpack/monitoring/_bulk`) does not interpret `_type` in the bulk metadata the same was as the regular Bulk API (`POST _bulk`). In the case of the Monitoring Bulk API, `_type` has a special meaning. It does not correspond to the Elasticsearch document `_type` but rather a `type` field within monitoring documents. The `_type` of those monitoring documents gets automatically set to `_doc` by the Monitoring Bulk API. Therefore, the Beats monitoring code should always send `_type` to the Monitoring Bulk API.
ruflin
added a commit
that referenced
this pull request
Mar 19, 2019
The Monitoring Bulk API (`POST _xpack/monitoring/_bulk`) does not interpret `_type` in the bulk metadata the same was as the regular Bulk API (`POST _bulk`). In the case of the Monitoring Bulk API, `_type` has a special meaning. It does not correspond to the Elasticsearch document `_type` but rather a `type` field within monitoring documents. The `_type` of those monitoring documents gets automatically set to `_doc` by the Monitoring Bulk API. Therefore, the Beats monitoring code should always send `_type` to the Monitoring Bulk API. (cherry picked from commit ac72b5c)
ycombinator
added
the
needs_backport
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Monitoring Bulk API (
POST _xpack/monitoring/_bulk) does not interpret_typein the bulk metadata the same was as the regular Bulk API (POST _bulk). In the case of the Monitoring Bulk API,_typehas a special meaning. It does not correspond to the Elasticsearch document_typebut rather atypefield within monitoring documents. The_typeof those monitoring documents gets automatically set to_docby the Monitoring Bulk API.Therefore, the Beats monitoring code should always send
_typeto the Monitoring Bulk API.