Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instance.state.name into fields.yml #11221

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Add instance.state.name into fields.yml #11221

merged 3 commits into from
Mar 13, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 13, 2019 •
edited
Loading

This PR is to fix error on Kibana: Could not locate that index-pattern-field (id: aws.ec2.instance.state.name).
closes #11219

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 13, 2019
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners March 13, 2019 03:17
@kaiyan-sheng kaiyan-sheng added bug v7.0.0 Team:Integrations Label for the Integrations team needs_backport PR is waiting to be backported to other branches. labels Mar 13, 2019
@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 13, 2019
Closed
ruflin
ruflin approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be great to have long term tests that can also validate these fields are documented.

@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 13, 2019
Closed
@kaiyan-sheng
Copy link
Contributor Author

Yes! #11226 I created this to track adding validation. Thank you.

@kaiyan-sheng kaiyan-sheng merged commit efcf034 into elastic:master Mar 13, 2019
@kaiyan-sheng kaiyan-sheng deleted the ec2_fields branch March 13, 2019 13:29
@kaiyan-sheng kaiyan-sheng removed needs_backport PR is waiting to be backported to other branches. v7.0.0 labels Mar 13, 2019
kaiyan-sheng added a commit that referenced this pull request Mar 13, 2019
@kaiyan-sheng
Cherry-pick to 7.0: Add instance.state.name into fields.yml (#11221) (#…
781be04 
…11228)

* Add instance.state.name into fields.yml (#11221)

* Add instance.state.name into fields.yml

* Rebase and regenerate fields.yml

* Update changelog

(cherry picked from commit efcf034)

* Rerun mage update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing aws.ec2.instance.state.name in fields.yml
2 participants
@kaiyan-sheng @ruflin