Skip flaky ES integration tests for now #11230
Conversation
| @@ -100,6 +101,7 @@ func TestFetch(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestData(t *testing.T) { | |||
| t.Skip("flaky") | |||
There was a problem hiding this comment.
This is an interesting one. We started to remove the compose.EnsureUp in the data tests as they are skipped anyways later on. Perhaps try to also in your other PR. The idea is that we move this to the new data tests framework. Having the Stack modules there too would be great. Please ping me if you need more details.
There was a problem hiding this comment.
@ruflin If you could point me to a PR that shows a module moving to the new data tests framework, that would be very helpful. If it's too much trouble, I can look around in the code and try to figure it out too.
There was a problem hiding this comment.
Here is an example: #11112 But we should probably still sync up as Elasticsearch is a bit different because it needs more then 1 endpoint available which is not supported yet (but we should add it).
|
@ycombinator I merged this PR to bring our builds back to green, I hope you don't mind. |
|
Does this fix errors such as this one, that I'm seeing on the 7.0 branch: PR, test failure? If that's the case, can we backport this to 7.0 as well? I'm willing to do it, if it's appropriate. |
|
Thanks @ruflin. |
Debugging flakiness over here: #11224