Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix a typo in libbeat/outputs/transport/client.go #11242

Merged
merged 3 commits into from
Mar 26, 2019
Merged

bugfix: fix a typo in libbeat/outputs/transport/client.go #11242

merged 3 commits into from
Mar 26, 2019

Conversation

moooofly
Copy link
Contributor

I think there is a bug in https://github.com/elastic/beats/blob/master/libbeat/outputs/transport/client.go#L177

  • original
func (c *Client) RemoteAddr() net.Addr {
	conn := c.getConn()
	if conn != nil {
		return c.conn.LocalAddr()
	}
	return nil
}
  • update
func (c *Client) RemoteAddr() net.Addr {
	conn := c.getConn()
	if conn != nil {
		return c.conn.RemoteAddr()
	}
	return nil
}

@moooofly moooofly requested a review from a team as a code owner March 14, 2019 06:39
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ph
Copy link
Contributor

ph commented Mar 20, 2019

Jenkins test this please

@ph
Copy link
Contributor

ph commented Mar 20, 2019

@moooofly Yup indeed it look like a typo, do you mind adding a changelog item to https://github.com/elastic/beats/blob/master/CHANGELOG.next.asciidoc ?

@moooofly
Copy link
Contributor Author

@ph OK, I will do it.

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just restarting some failed test, they failed because of networks error on Travis.

@moooofly
Copy link
Contributor Author

Is there something I can do? @ph 😃

@ph ph merged commit d834ac4 into elastic:master Mar 26, 2019
@ph
Copy link
Contributor

ph commented Mar 26, 2019

@moooofly merged thanks for the PR!

@moooofly moooofly deleted the fix_type_in_libbeat_outout_transport_client branch March 28, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants