Don't collect empty ip addresses in docker container metricset #11247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker containers can have empty ip addresses if they are running in host network mode or if they are stopped. Collecting lists with empty addresses can make type mapping to fail when trying to store them as ip addresses.
jsoriano
added
bug
module
review
Metricbeat
kaiyan-sheng
approved these changes
Mar 14, 2019
ruflin
approved these changes
Mar 15, 2019
| @@ -71,7 +71,9 @@ func eventMapping(r mb.ReporterV2, cont *types.Container, dedot bool) { | |||
| func extractIPAddresses(networks *types.SummaryNetworkSettings) []string { | |||
| ipAddresses := make([]string, 0, len(networks.Networks)) | |||
There was a problem hiding this comment.
With this change ipAddresses is now not anymore len(networks.Networks). Is it mainly in testing that it might be empty or a common case? Thinking which use case we should optimise for.
There was a problem hiding this comment.
I though about this and I think that in most of the cases ipAddresses is still going to be len(networks.Networks).
The most common case where this is not going to be true is when the container is using the host network, in that case we would be creating an array of capacity one that we are not going to use.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 18, 2019
…ic#11247) Docker containers can have empty ip addresses if they are running in host network mode or if they are stopped. Collecting lists with empty addresses can make type mapping to fail when trying to store them as ip addresses. Fix elastic#11225 (cherry picked from commit 258c1c8)
jsoriano
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker containers can have empty ip addresses if they are running in
host network mode or if they are stopped. Collecting lists with empty
addresses can make type mapping to fail when trying to store them as ip
addresses.
It only affects 7.0 because before these ip addresses were of type
keyword.Fix #11225