Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingest pipelines to use event.timezone #11248

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Update ingest pipelines to use event.timezone #11248

merged 2 commits into from
Mar 14, 2019

Conversation

adriansr
Copy link
Contributor

Previously, beats.timezone was used, in 7.0+ it's not available anymore. However, some ingest pipelines were still using it.

@adriansr
Update ingest pipelines to use event.timezone
8ae5ebc 
Previously, `beats.timezone` was used, in master it's not available
anymore. However, some ingest pipelines were still using it.
@adriansr adriansr requested a review from a team as a code owner March 14, 2019 13:32
@ruflin ruflin added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. labels Mar 14, 2019
ruflin
ruflin approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also added the needs_backport label.

Our CI did not catch this I assume because we have ignore_failure: true :-(

@adriansr adriansr requested a review from a team as a code owner March 14, 2019 15:10
@adriansr adriansr merged commit 1946505 into elastic:master Mar 14, 2019
adriansr added a commit to adriansr/beats that referenced this pull request Mar 14, 2019
@adriansr
Update ingest pipelines to use event.timezone (elastic#11248)
6739b6f 
* Update ingest pipelines to use event.timezone

Previously, `beats.timezone` was used, in master it's not available
anymore. However, some ingest pipelines were still using it.

(cherry picked from commit 1946505)
@adriansr adriansr mentioned this pull request Mar 14, 2019
Merged
@adriansr adriansr added v7.0.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 14, 2019
adriansr added a commit that referenced this pull request Mar 15, 2019
@adriansr
Update ingest pipelines to use event.timezone (#11248) (#11257)
03a9428 
Previously, `beats.timezone` was used, in master it's not available
anymore. However, some ingest pipelines were still using it.

(cherry picked from commit 1946505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat review v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansr @ruflin