Rename migration.enabled to migration.6_to_7.enabled #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Mar 18, 2019
|
This will need a rebase and update as soon as #11284 is merged. Changelog entry should be added. |
This is to make it more clear this is for the migration from 6.7 to 7.0.
ruflin
force-pushed
the
rename-migration
branch
from
943788d
to
b87781a
Compare
|
I'd keep This option could be called |
|
I agree with @jsoriano. If his proposal is too verbose, perhaps |
|
No strong opinions on naming. I'm going with |
jsoriano
approved these changes
Mar 19, 2019
|
Failing test seems related to migration. |
|
Yes, already fixed, missed one renaming. |
jsoriano
approved these changes
Mar 19, 2019
ruflin
changed the title
|
@dedemorton FYI, the config name changed. |
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Mar 19, 2019
This is to make it more clear this is for the migration from 6.7 to 7.0. (cherry picked from commit 38c81eb)
ruflin
added a commit
that referenced
this pull request
Mar 19, 2019
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
This is to make it more clear this is for the migration from 6.7 to 7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it more clear this is for the migration from 6.7 to 7.0.