Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use multiline options in Logstash module with json format #11346

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Don't use multiline options in Logstash module with json format #11346

merged 1 commit into from
Mar 21, 2019

Conversation

jsoriano
Copy link
Member

Multiline options were being applied to json log files with unexpected
results as several lines joined or lines lost.

@jsoriano jsoriano added bug module review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Feature:Stack Monitoring labels Mar 20, 2019
@jsoriano jsoriano self-assigned this Mar 20, 2019
@jsoriano jsoriano requested a review from a team as a code owner March 20, 2019 15:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

@jsoriano jsoriano force-pushed the filebeat-logstash-json-multiline branch from f437132 to 2db2f00 Compare March 20, 2019 16:05
ycombinator
ycombinator approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WFG.

@jsoriano
Copy link
Member Author

jenkins, test this again please

@jsoriano jsoriano merged commit f76f293 into elastic:master Mar 21, 2019
@jsoriano jsoriano deleted the filebeat-logstash-json-multiline branch March 21, 2019 10:13
@jsoriano jsoriano mentioned this pull request Mar 25, 2019
Merged
@jsoriano jsoriano added v7.0.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 25, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Mar 25, 2019
@jsoriano
Don't use multiline options in Logstash module with json format (elas…
9f743fc 
…tic#11346)

(cherry picked from commit f76f293)
jsoriano added a commit that referenced this pull request Mar 26, 2019
@jsoriano
Don't use multiline options in Logstash module with json format (#11346…
5c59456 
…) (#11445)

(cherry picked from commit f76f293)
@ycombinator ycombinator mentioned this pull request Apr 2, 2019
Merged
ycombinator pushed a commit to ycombinator/beats that referenced this pull request Apr 2, 2019
@jsoriano @ycombinator
Don't use multiline options in Logstash module with json format (elas…
6ce8ab4 
…tic#11346)

(cherry picked from commit f76f293)
ycombinator added a commit that referenced this pull request Apr 2, 2019
@ycombinator
Cherry-pick #11346 to 6.7: Don't use multiline options in Logstash mo…
f1b55d7 
…dule with json format (#11601)

Cherry-pick of PR #11346 to 6.7 branch. Original message: 

Multiline options were being applied to json log files with unexpected
results as several lines joined or lines lost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@jsoriano jsoriano

Labels
bug Feature:Stack Monitoring Filebeat Filebeat module review v6.7.1 v6.7.2 v7.0.0 v7.0.1 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @ycombinator