Cherry-pick #11357 to 6.6: Fix Winlogbeat escaping CRLF sequences #11370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fix (elastic#11006) made Winlogbeat escape CRLF control characters which are expected in Windows event logs. Fixes elastic#11328 (cherry picked from commit 6865403)
adriansr
force-pushed
the
backport_11357_6.6
branch
from
4e5e7d0
to
9c8cbb6
Compare
The new system test added in elastic#11357 checks for the wrong field in 6.7 and 6.6.
andrewkroh
reviewed
Mar 25, 2019
| evts = self.read_events() | ||
| self.assertTrue(len(evts), 1) | ||
| self.assertEqual(unicode(self.api), evts[0]["type"], evts[0]) | ||
| self.assertNotIn("event.original", evts[0], msg=evts[0]) |
There was a problem hiding this comment.
Do we use event.original in 6.6? I think the value goes to xml instead.
andrewkroh
approved these changes
Mar 27, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ces (elastic#11370) Previous fix (elastic#11006) made Winlogbeat escape CRLF control characters which are expected in Windows event logs. Fixes elastic#11328 (cherry picked from commit 5db0f15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #11357 to 6.6 branch. Original message:
Previous fix (#11006) made Winlogbeat escape CRLF control characters, which are expected in Windows event logs.
Fixes #11328