Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IP fields from default_field in Elasticsearch template #11402

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Remove IP fields from default_field in Elasticsearch template #11402

merged 1 commit into from
Mar 25, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Mar 22, 2019

Removes IP fields from the default_field array in the generated Elasticsearch template.

Further details in the 6.7 PR: #11399

@cwurm cwurm requested a review from ruflin March 22, 2019 20:09
@cwurm cwurm requested a review from a team as a code owner March 22, 2019 20:09
@ruflin
Copy link
Member

ruflin commented Mar 25, 2019

It seems in the past when using _all, lenient: true was automatically applied. I'm wondering now if not field is set and default_fields are used, Elasticsearch should also set lenient: true automatically? @jasontedor Perhaps you can chime in here?

@ruflin ruflin merged commit cbd7749 into elastic:master Mar 25, 2019
@ruflin
Copy link
Member

ruflin commented Mar 25, 2019

@jasontedor We had a separate discussion around this today in the morning it's clear that this will not happen in ES for various reason, no need to comment ;-)

@ruflin ruflin self-assigned this Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin Awaiting requested review from ruflin

Assignees

@ruflin ruflin

Labels
bug libbeat review v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwurm @ruflin