Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] migrate envoyproxy module to ReporterV2 error #11412

Merged

Conversation

berfinsari
Copy link
Contributor

See #11374 and #10727

@berfinsari berfinsari requested a review from a team as a code owner March 23, 2019 23:57
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin
Copy link
Member

ruflin commented Mar 25, 2019

jenkins, test this

@ruflin ruflin added module review Team:Integrations Label for the Integrations team Metricbeat Metricbeat labels Mar 25, 2019
@berfinsari
Copy link
Contributor Author

Is there anything that I can do for this unsuccessful check?

@fearful-symmetry
Copy link
Contributor

Jenkins failure seems unrelated.

@fearful-symmetry
Copy link
Contributor

jenkins, test this

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you rebase on master?

@berfinsari berfinsari force-pushed the migration/mb/reporterv2error/envoyproxy branch from ae25136 to 74f1f77 Compare March 27, 2019 17:13
@ruflin
Copy link
Member

ruflin commented Mar 28, 2019

jenkins, test this

@ruflin ruflin merged commit 8cceee6 into elastic:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants