Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore default make target and allow some overrides #11541

Merged
merged 3 commits into from
Apr 5, 2019
Merged

restore default make target and allow some overrides #11541

merged 3 commits into from
Apr 5, 2019

Conversation

graphaelli
Copy link
Member

  • fixes default make target used by the docs
  • allows clean override of some make targets used by APM server

APM server currently emits these with some version of make (including the default on mac os):

Makefile:47: warning: overriding commands for target `check-headers'
_beats/libbeat/scripts/Makefile:135: warning: ignoring old commands for target `check-headers'
Makefile:55: warning: overriding commands for target `add-headers'
_beats/libbeat/scripts/Makefile:142: warning: ignoring old commands for target `add-headers'
Makefile:148: warning: overriding commands for target `import-dashboards'
_beats/libbeat/scripts/Makefile:387: warning: ignoring old commands for target `import-dashboards'

It seems reasonable to allow those to be overridden.

@graphaelli graphaelli requested a review from a team as a code owner March 29, 2019 15:27
webmat
webmat approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphaelli graphaelli merged commit 5554677 into elastic:master Apr 5, 2019
@graphaelli graphaelli deleted the make-tricks branch April 5, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

@urso urso urso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graphaelli @webmat @urso