Add TLS support for metric beat http server #11611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
kaiyan-sheng
reviewed
Apr 2, 2019
andrewkroh
reviewed
Apr 2, 2019
| @@ -130,6 +148,11 @@ func (h *HttpServer) handleFunc(writer http.ResponseWriter, req *http.Request) { | |||
|
|
|||
| case "GET": | |||
| writer.WriteHeader(http.StatusOK) | |||
| writer.Write([]byte("HTTP Server accepts data via POST")) | |||
| if h.server.TLSConfig != nil && h.server.TLSConfig.Certificates != nil { | |||
There was a problem hiding this comment.
The request itself can tell you if it was received over TLS: if req.TLS != nil. Sorry to bother you about this line again, but the thought came to be late.
There was a problem hiding this comment.
No problem. It looks better this way. Let me test it...
There was a problem hiding this comment.
@andrewkroh Done, tested ok
Update config.go Update http.go Update config.go Adding ssl tests, adjusting review requests Line update Line Update req.TLS check
andrewkroh
approved these changes
Apr 2, 2019
|
jenkins, test this |
urso
reviewed
Apr 13, 2019
| @@ -130,6 +148,11 @@ func (h *HttpServer) handleFunc(writer http.ResponseWriter, req *http.Request) { | |||
|
|
|||
| case "GET": | |||
| writer.WriteHeader(http.StatusOK) | |||
| writer.Write([]byte("HTTP Server accepts data via POST")) | |||
| if req.TLS != nil { | |||
| writer.Write([]byte("HTTPS Server accepts data via POST")) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #11457