[Metricbeat] migrate postgres to ReporterV2 with new error handling #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
|
jenkins, test this |
fearful-symmetry
force-pushed
the
migration/mb/reporterv2error/postgres
branch
from
6fd7b79
to
56fc8ac
Compare
ruflin
approved these changes
Apr 4, 2019
| @@ -42,6 +42,7 @@ func init() { | |||
| } | |||
| } | |||
|
|
|||
| //NewModule returns a new instance of the module | |||
There was a problem hiding this comment.
Nit: we normally add a space after the //. Applies to few other places.
Thanks for adding the missing doc blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11374
I removed the
ReportingFetchV2()calls fromTestData(), asWriteEventsReporterV2Error()should check to make sure it has data.Also cleaned things up so the linters should be happy.