Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cluster_name from under cluster_stats field #11654

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Remove cluster_name from under cluster_stats field #11654

merged 1 commit into from
Apr 8, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 4, 2019 •
edited
Loading

We already index the cluster_name field as a top-level field in .monitoring-es-* docs with type: cluster_stats. So we don't need to index it under the cluster_stats top-level field as well.

Testing this PR

  1. Pull down this PR and build Metricbeat. 
    cd metricbeat
mage build
  2. Enable the elasticsearch Metricbeat module. 
    ./metricbeat modules enable elasticsearch
  3. Edit modules.d/elasticsearch.yml and make sure the cluster_stats metricset is enabled. Also set xpack.enabled: true for the module.
  4. Start Metricbeat 
    ./metricbeat -e
  5. Using Kibana Console check that the Metricbeat-indexed monitoring documents for Elasticsearch don't contain the cluster_stats.cluster_name field. 
    GET .monitoring-es-7-mb-*/_search?q=type:cluster_stats

@ycombinator ycombinator requested a review from a team as a code owner April 4, 2019 18:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

cachedout
cachedout approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using instructions provided in the PR and results were as expected.

@ycombinator ycombinator merged commit 23702d6 into elastic:master Apr 8, 2019
@ycombinator ycombinator deleted the mb-es-xp-cs-cn branch April 8, 2019 16:06
@ycombinator ycombinator mentioned this pull request Apr 26, 2019
Merged
@ycombinator ycombinator mentioned this pull request Jul 19, 2019
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

Assignees
No one assigned
Labels
Feature:Stack Monitoring Metricbeat Metricbeat module review v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @elasticmachine @cachedout