Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating monitoring docs with direct monitoring configuration #11678

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 5, 2019

Beats now have the ability to send their monitoring data directly to the monitoring Elasticsearch cluster (#9260). This PR updates the Beats monitoring documentation with this change.

Resolves #11637.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

@lcawl
Copy link
Contributor

lcawl commented Apr 5, 2019

I added a few minor updates to the X-Pack terminology and links. Hope that's okay!

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too!

@ycombinator ycombinator merged commit aa8df15 into elastic:master Apr 6, 2019
@ycombinator ycombinator deleted the monitoring-update-docs branch April 8, 2019 18:42
@bmorelli25
Copy link
Member

Follow up question on this PR. @lcawl, @dedemorton
Any reason why we removed xpack.monitoring.enabled from the documentation entirely, instead of marking it as deprecated?

@bmorelli25
Copy link
Member

Also curious as to if the name "Xpack Monitoring" was purposefully left in the yml file?

https://github.com/elastic/beats/pull/11677/files#diff-0605d738822e1c7e296523bf9f4d20b1R1180

@dedemorton
Copy link
Contributor

@ycombinator is probably the best person to answer @bmorelli25.

Incidentally, I'm running 7.0, and Kibana stops displaying Beats monitoring data if I remove xpack form this setting. Might be doing something wrong because I'm doing minimal setup to test privileges (not monitoring). The monitoring docs still need work....

@ycombinator
Copy link
Contributor Author

Any reason why we removed xpack.monitoring.enabled from the documentation entirely, instead of marking it as deprecated?

I'm okay with leaving it and marking it as deprecated in the docs. I guess it depends on what our general policy around documenting deprecated settings is. @lcawl @dedemorton?

Also curious as to if the name "Xpack Monitoring" was purposefully left in the yml file?

This is an interesting one for sure. As this is a comment header in the yml file, I took it to mean the name of the feature, not necessarily strongly tied to the names of the settings under that header. Again, I'm open to changing this to just "Monitoring" too.

Incidentally, I'm running 7.0, and Kibana stops displaying Beats monitoring data if I remove xpack form this setting.

I commented on this here: #11329 (comment).

@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Beats monitoring docs re: direct shipping to monitoring cluster
5 participants