Cherry-pick #11494 to 6.7: Update github.com/elastic/go-sysinfo #11710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#11490 Fixes elastic#9134 (cherry picked from commit e044c9c)
andrewkroh
force-pushed
the
backport_11494_6.7
branch
from
b2c806b
to
251f66e
Compare
exekias
approved these changes
Apr 9, 2019
cwurm
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
LGTM. Since this also contains fixes to reduce false positives for host.containerized and to fill host.UniqueID on older Linux versions such as Ubuntu 14.04 you could add that to the changelog.
Fyi, I have a PR open to update go-sysinfo with even newer changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #11494 to 6.7 branch. Original message:
Fixes #11490
Fixes #9134