Monitoring parity test: better type comparisons #11720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by failure in https://travis-ci.org/elastic/beats/jobs/517696747:
In the case of this failure, the type check is a bit too strict. We really only care that the two values are numbers. This PR makes the necessary changes.
Additionally, it also does a bit of cleanup by using
isinstance
instead oftype
to determine if a value is a dictionary. Apparently this is the more Pythonic way.