Cherry-pick to 7.0: Change add_cloud_metadata to not overwrite cloud field (#11612) #11730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change add_cloud_metadata to not overwrite cloud field * Add overwrite flag for add_cloud_metadata * Add test for cloud.provider: ec2 * Update processors-using.asciidoc (cherry picked from commit 17edc90)
|
It seems this is broken, maybe there is a missing backport? |
|
Please don't merge until 7.0 has been released 👍 |
@exekias That was my bad, my mistake on resolving conflict. Now it's fixed. |
exekias
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 17edc90)