[Metricbeat] Migrate Dropwizard collector Metricset to use ReporterV2Error interface #11743
Conversation
sayden
added
review
Metricbeat
| "p99": 0, | ||
| "p999": 0, | ||
| "stddev": 0 | ||
| "_namespace": "testnamespace", |
There was a problem hiding this comment.
This should not be here anymore I would assume?
There was a problem hiding this comment.
I thought that we could maintain it just for compatibility but I can remove it, of course.
There was a problem hiding this comment.
I don't think this was in the previous events.
| } | ||
|
|
||
| eventList := eventMapping(dw) | ||
|
|
||
| // Converts hash list to slice | ||
| events := []common.MapStr{} | ||
| for _, event := range eventList { | ||
| event[mb.NamespaceKey] = m.namespace |
There was a problem hiding this comment.
This line can probably be removed?
| @@ -67,19 +71,14 @@ func TestFetch(t *testing.T) { | |||
| } | |||
| assert.Equal(t, hasTag, true) | |||
There was a problem hiding this comment.
Do we only need to check hasTag once after all for _, event := range events {} loops?
There was a problem hiding this comment.
Uhmmm 🤔 You are right. I'll leave it for a follow up PR, I'm looking forward to finish with the migration and this was like this already anyways 😅
|
|
||
| t.Logf("%s/%s event: %+v", f.Module().Name(), f.Name(), events) | ||
| } | ||
|
|
||
| func TestData(t *testing.T) { | ||
| compose.EnsureUp(t, "dropwizard") | ||
| f := mbtest.NewReportingMetricSetV2Error(t, getConfig()) |
There was a problem hiding this comment.
Now that we have the new data generation, we could remove TestData?
|
Error is unrelated. Merging |
Refer to #10774 for more info