Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat] migrate Redis to reporterV2 with error #11792

Merged
merged 2 commits into from
Apr 15, 2019
Merged

[metricbeat] migrate Redis to reporterV2 with error #11792

merged 2 commits into from
Apr 15, 2019

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Apr 12, 2019 •
edited by alvarolobato
Loading

See #11374

@fearful-symmetry fearful-symmetry added Metricbeat Metricbeat Team:Integrations Label for the Integrations team technical_debt labels Apr 12, 2019
@fearful-symmetry fearful-symmetry requested a review from a team April 12, 2019 19:51
@fearful-symmetry fearful-symmetry self-assigned this Apr 12, 2019
@fearful-symmetry fearful-symmetry mentioned this pull request Apr 12, 2019
Closed
93 tasks
@fearful-symmetry
Copy link
Contributor Author

jenkins, test this

@fearful-symmetry
Copy link
Contributor Author

We still have to revert to the generate message-log-report inside a loop, it seems.

ruflin
ruflin approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry Not sure I got your last comment.

@fearful-symmetry fearful-symmetry merged commit 2499449 into elastic:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fearful-symmetry @ruflin