Refactoring: use new Fetch interface that automatically reports and logs errors #11795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2019
ycombinator
changed the title
ycombinator
added
in progress
|
Pinging @elastic/stack-monitoring |
cachedout
approved these changes
Apr 13, 2019
ycombinator
force-pushed
the
refactoring-mb-es-fetch
branch
from
3148add
to
24374ea
Compare
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors code in the
elasticsearchMetricbeat module to use the newFetchinterface introduced in #10727.Note that x-pack code paths in this module were not refactored to use the new interface as we don't want errors from those code paths to be reported into
metricbeat-*indices, only logged to Metricbeat logs.Related: #11763 and #11767.