Cherry-pick #12099 to 7.x: Skip Windows testing if magefile.go does not exist #12127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the jenkins_ci.ps1 script to skip testing when magefile.go does not exist. This will allow us to add projects like x-pack/winlogbeat to the test matrix because not all branches have an x-pack/winlogbeat/magefile.go file. (cherry picked from commit cc05f62)
|
@andrewkroh My assumption is this backport still happens "magically"? |
|
This one can't/shouldn't wait otherwise 7.x will be broken on our CI. I'm going to be changing the JJB next. But if were OK with jenkins being red until the next bulk backport then I'm good with closing this one. |
|
Making one change in a Jenkinsfile on master only would be so much easier. 😢 |
|
@andrewkroh I would rather to "one more bulk backport" as I worry that this might mix up things. Being red on 7.x sounds ok to me but @urso should chime in. ++ on doing a change in a Jenkinsfile ;-) |
|
No problem, I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12099 to 7.x branch. Original message:
Changes the jenkins_ci.ps1 script to skip testing when magefile.go does not
exist. This will allow us to add projects like x-pack/winlogbeat to the test
matrix because not all branches have an x-pack/winlogbeat/magefile.go
file.
The next step will be to add x-pack/winlogbeat to the test matrix in the JJB config. And cherry-pick this into the other branches that we are actively maintaining and testing on Jenkins.