Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #12125 to 6.8: Fix goroutine leak on initialization failures of log input #12144

Merged
merged 2 commits into from
May 10, 2019
Merged

Cherry-pick #12125 to 6.8: Fix goroutine leak on initialization failures of log input #12144

merged 2 commits into from
May 10, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 9, 2019

Cherry-pick of PR #12125 to 6.8 branch. Original message:

Detected on #12106, possibly related to #9302.

These outlets should be probably created on Run(), but it
cannot return an error. I'd fix it like this by now,
and would do further refactors on future PRs.

@jsoriano
Fix goroutine leak on initialization failures of log input (elastic#1…
f870930 
…2125)

Outlets are created during log input initialization, and if it
fails they were never freed. Handle this case.

(cherry picked from commit f2473d2)
@jsoriano
Copy link
Member Author

jenkins, test this again

@jsoriano jsoriano merged commit 44077a0 into elastic:6.8 May 10, 2019
@jsoriano jsoriano deleted the backport_12125_6.8 branch May 10, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @exekias