Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add 7.1, 7.2, 7.3, and 8.0 breaking changes files #12328

Merged
merged 6 commits into from
May 30, 2019

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented May 29, 2019

Adds 8.0 and 7.3 breaking changes. The files will not be hooked up to the navigation until we have an 8.x and 7.3 branches.

Also forward ports changes added in #12326 and #12322.

This PR must be merged at the same time as elastic/stack-docs#350

@dedemorton dedemorton requested a review from lcawl May 29, 2019 00:17
@dedemorton dedemorton requested a review from a team as a code owner May 29, 2019 00:17
@dedemorton dedemorton changed the title Add 7.1, 7.2, and 8.0 breaking changes files [DOCS] Add 7.1, 7.2, and 8.0 breaking changes files May 29, 2019
@lcawl
Copy link
Contributor

lcawl commented May 29, 2019

Would it save time to create a 7.3.0 page for the 7.x branch now too?

@lcawl
Copy link
Contributor

lcawl commented May 29, 2019

FYI in other products' docs we don't include the 7.* release notes or highlights or breaking changes in the 8.* books. e.g. https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes.html
Just mentioning in case you want to omit the 7.* pages. If that's not feasible because of the merge strategy in this repo, that's fine.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Beats Platform Reference builds successfully, but I added two comments for consideration.

@dedemorton
Copy link
Contributor Author

Just mentioning in case you want to omit the 7.* pages. If that's not feasible because of the merge strategy in this repo, that's fine.

Yes, that's exactly why I'm including the 7.x pages. I don't want to mess up the automerge from master > 7.x.

@dedemorton dedemorton changed the title [DOCS] Add 7.1, 7.2, and 8.0 breaking changes files [DOCS] Add 7.1, 7.2, 7.3, and 8.0 breaking changes files May 29, 2019
@dedemorton
Copy link
Contributor Author

@lcawl I've added the 7.3 file, too. Once we create an 8.x branch, we can clean out the 7.x files, but for now, let's keep all the 7.x files in master so the merge is simpler.

@dedemorton dedemorton merged commit 249e7ad into elastic:master May 30, 2019
@dedemorton dedemorton deleted the add_8.0_breaking_changes branch May 30, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants