[libbeat]add EC2 fields to yaml for add_cloud_metadata #12335
Conversation
odacremolbap
added
docs
review
libbeat
Team:Integrations
| @@ -44,3 +49,14 @@ | |||
| type: alias | |||
| path: cloud.region | |||
| migration: true | |||
|
|
|||
| - name: meta.cloud.account.id | |||
There was a problem hiding this comment.
Do not have the full context on this one but I wonder why migration: true is missing?
There was a problem hiding this comment.
I submitted another comment with the review 😇, I guess we don't need these alias cause they are primary minded for backwards compatibility, but these are new fields, isn't it?
There was a problem hiding this comment.
I copied it from existing fields.yml
I though that those fields needed to be defined at the event, and then aliased to ECS.
are there some docs on how to use this fields.yml at processors and how it fits with ECS?
There was a problem hiding this comment.
Sorry I don't think there are docs about this. These aliases were created in the context of ECS transition (see #9265 for more details). In a nutshell, old fields were not ECS compliant, so everything was moved to ECS fields, then old fields became aliases pointing to the new ones, as a way to allow smoother upgrades for users.
As you are adding new fields, there is no need to create alias from old names, as nobody is relying on these names for their visualizations
| @@ -44,3 +49,14 @@ | |||
| type: alias | |||
| path: cloud.region | |||
| migration: true | |||
|
|
|||
| - name: meta.cloud.account.id | |||
There was a problem hiding this comment.
These new alias are not needed. They were initially created for backwards compatibility with previous names. As these fields are new, we don't need to have them in the old layout
There was a problem hiding this comment.
I thought data from the processor was created under meta.cloud ... and then had to be aliased to ECS cloud. ...
idk how this works, but sounds like I just need to remove this block from fields.yml, and that somehow the field will be mapped to ECS
|
not sure if something is missing:
|
* add EC2 fields to yaml for add_cloud_metadata
Related to #12307
As mentioned here #12307 (comment)
Adding fields to yaml file for EC2 cloud metadata
@exekias