Fix Filebeat autodiscover hints default settings #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default settings were broken after elastic#12162, this code updates them to the new input and makes sure that enable/disable logic works correctly. Tests have been added to make sure this changes still work
exekias
added
bug
review
blocker
needs_backport
jsoriano
reviewed
May 29, 2019
| } else { | ||
| // full config provided, discard default | ||
| c.DefaultConfig = config | ||
| } |
There was a problem hiding this comment.
What if a full config is provided, but also with the enabled setting set to true?
Would this work?
hints.default_config:
type: container
enabled: true
paths:
- "/var/log/pods/${data.kubernetes.pod.uid}/${data.kubernetes.container.name}/*.log"
There was a problem hiding this comment.
It should, as I'm checking number of fields == 1
jsoriano
approved these changes
May 29, 2019
kaiyan-sheng
approved these changes
May 29, 2019
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
May 29, 2019
Default settings were broken after elastic#12162, this code updates them to the new input and makes sure that enable/disable logic works correctly. Tests have been added to make sure this changes still work (cherry picked from commit 289c984)
exekias
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#12356) Default settings were broken after elastic#12162, this code updates them to the new input and makes sure that enable/disable logic works correctly. Tests have been added to make sure this changes still work (cherry picked from commit 66fe637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default settings were broken after #12162, this code updates them to the
new input and makes sure that enable/disable logic works correctly.
Tests have been added to make sure this changes still work.
Fixes #12346