Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libbeat] AWS ELB Monitoring #12401
[libbeat] AWS ELB Monitoring #12401
Changes from all commits
72894c5
ab4a73d
d0bdd60
2c69797
5e223ba
c54f02d
53b53e0
f83d586
3735992
3a27a98
885eda8
900b2fd
9694836
e5db213
338afdc
d7b7982
2173a3e
48285fa
64b2d60
7de2b77
eda8ef2
9e7fd30
381e161
e98297f
5298de2
4c7dab9
9b62b34
b43d8cf
bc22929
023a46c
c401af9
31f72d0
07de1e3
4e5f001
05b42a6
26c87ba
f9ad369
1e9ecca
1f00ab3
4fc44ee
06d3f08
a23a8b7
338fabb
03752cd
89cab2f
0f883d1
c449d3c
e5b8a8c
e0202ec
1b078e4
462d0de
ceedb5b
dce76e4
f5d8a69
11ab929
0a1ba5a
d8e7230
555fd32
adf4d23
3817d9b
c279606
7242238
0d075ec
282cec2
7056db5
563e85d
d35e091
a5340f1
ee5fdde
aa019c3
bf2904e
7a6f151
431c5f6
9a53417
0af6bd4
f8683a0
e120361
abfb978
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly but I thought worth mentioning: This is not following ECS but is the same in other autodiscovery providers. I wonder if long term this could become an issue if we would also ingest some autodiscovery data for later querying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
host
andport
fields aren't inserted into the event. Only theelb_listener
fields are. The fields listed here are what are present in the templating phase of the config. I'll add info here to clarify.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that it's not added to the event, but I'm still thinking if we should potentially align to prevent confusion? @exekias ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think there is some confusion here. Those fields do contain their own
host
andport
fields. Additionally, if using heartbeat you'd probably useurl.port
andurl.domain
anyway.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.