Add max_connections to TCP input #12691
Conversation
|
this looks ok, what i'm thinking about is whether or not is this solving root cause. |
filebeat/input/tcp/config.go
Outdated
| @@ -40,6 +40,7 @@ var defaultConfig = config{ | |||
| Config: tcp.Config{ | |||
| Timeout: time.Minute * 5, | |||
| MaxMessageSize: 20 * humanize.MiByte, | |||
| MaxConnections: 10, | |||
There was a problem hiding this comment.
What are the effects of this default value on a typical node? Are we confident that this is high enough not to artificially bottleneck a node that was previously handling a higher load? I'd be happier if this value was higher, or if the default was "no maximum"
There was a problem hiding this comment.
Good point! Updated the configuration to be unlimited by default.
|
@michalpristas I have addressed your concerns in the relevant issue. It is indeed a workaround, proper solution, if it exists at all, needs more investigation. |
| # Max number of concurrent connections. Default: 10 | ||
| #maxconn: 10 | ||
| # Max number of concurrent connections. By default it is not limited. | ||
| #maxconn: 0 |
There was a problem hiding this comment.
It looks like "maxconn" doesn't exist in the configuration, was this supposed to be removed?
Also make the documentation more explicit (after moving it below), e.g. "Max number of concurrent connections, or 0 for no limit. Default: 0"
|
Failing tests are unrelated. |
New configuration option is added to the TCP input of Filebeat to limit the number of incoming connections. By default it is set to 0 which means, it's unlimited.
Vendored
golang.org/x/net/netutil