Try to make kafka downloads more robust #12715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloads of kafka when building the docker image for metricbeat tests fail frequently, the error is reported by tar, saying that the downloaded object is not a tar. This can happen if curl downloads a result page as the result of a 3XX or 4XX response. This change makes curl follow redirects, and fail on any status code >= 400. Retries with exponential backoff till 3 minutes are done now when these errors happen.
jsoriano
added
module
review
Metricbeat
|
jenkins, test this again please |
|
jenkins, test this again please |
|
Flaking error is #12743 |
|
jenkins, test this again |
exekias
approved these changes
Jul 3, 2019
|
I am cherry-picking #12743 before merging both because I don't know why the issue solved by the other PR happens so frequently here. |
jsoriano
force-pushed
the
metricbeat-kafka-download-retry
branch
from
1f2101f to
f77bcc6
Compare
|
It passed, reverting to the approved change and updating with master. |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 8, 2019
Add retries and better error handling as done for kafka in elastic#12715.
jsoriano
added a commit
that referenced
this pull request
Aug 9, 2019
Add retries and better error handling as done for kafka in #12715.
sorantis
pushed a commit
to sorantis/beats
that referenced
this pull request
Aug 9, 2019
Add retries and better error handling as done for kafka in elastic#12715.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 16, 2021
Add retries and better error handling as done for kafka in elastic#12715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloads of kafka when building the docker image for metricbeat tests
fail frequently, the error is reported by tar, saying that the
downloaded object is not a tar. This can happen if curl downloads a
result page as the result of a 3XX or 4XX response.
This change makes curl follow redirects, and fail on any status code >=
400. Retries with exponential backoff till 3 minutes are done now
when these errors happen.
If this doesn't reduce the number of failures next step would be to
retry with apache archive mirrors.