Small pipeline enhancements #12996
Merged
Small pipeline enhancements #12996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 20, 2019
added 3 commits
July 22, 2019 21:30
Note: these changes are required to prepare for some refactoring in filebeat. Introduce OutputChooses publisher mode. Normally this is equivalent to the default mode for most Beats. But we introduce a new mode here, as filebeat sets the default mode to GuaranteedSend. This allows custom inputs to overwrite the default mode in filebeat in the future. Using beats.ProcessorList and the processors list to combine processors from different configurations is a little tricky. To simplify the task, we make sure that beat.ProcessorList implements processors.Processor. We also export processors.NewList, that can be used to compose a set of custom processors.Processor and beats.ProcessorList. The list returned by processors.NewList also implements beats.ProcessorList. It's not nice, but at least makes processors composable.
urso
force-pushed
the
small-pipeline-enhancements
branch
from
78ff9b5
to
b095bc8
Compare
ph
approved these changes
Jul 22, 2019
|
Failing test is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: these changes are required to prepare for some refactoring in
filebeat.
Introduce OutputChooses publisher mode. Normally this is equivalent to
the default mode for most Beats. But we introduce a new mode here, as filebeat sets the default mode
to GuaranteedSend. This allows custom inputs to overwrite the default
mode in filebeat in the future.
Using beats.ProcessorList and the processors list to combine processors
from different configurations is a little tricky. To simplify the task,
we make sure that beat.ProcessorList implements processors.Processor.
We also export processors.NewList, that can be used to compose a set of
custom processors.Processor and beats.ProcessorList. The list returned
by processors.NewList also implements beats.ProcessorList.
It's not nice, but at least makes processors composable.