Cherry-pick #12401 to 7.x: [libbeat] AWS ELB Monitoring #13105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental autodiscovery provider for AWS ELBs. (cherry picked from commit 2c85c97)
andrewvc
added
the
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
|
@andrewvc please do not backport to 7.x |
urso
pushed a commit
to urso/beats
that referenced
this pull request
Aug 2, 2019
This reverts commit a82ed33.
|
Apologies, it's weird switching back and forth between Kibana where this is normal and beats. Will try to do better in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12401 to 7.x branch. Original message:
Autodiscovery provider for AWS ELBs.
Not a lot to add besides that, the rest is in the docs provided within this PR.
One open question is the amount of testing to do here. We're still not sure if we want to introduce this as a beta feature, which might change the answer there. Ultimately, the AWS library is very tricky to mock. There is an elasticloadbalancingv2iface package that supposedly makes things easier, but realistically, you have to implement so much the value of that is dubious. Real functional testing with the AWS APIs is probably the only satisfactory answer, but that too is a significant investment.