Allow space or time sync character before timestamp #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
ok to test |
urso
added
the
Team:Services
|
Hi, unfortunately this PR hasn't been reviewed yet by us. Maybe you can rebase it on top of master? @ph can you please have a look? |
candlerb
force-pushed
the
candlerb/13269
branch
from
e474e24 to
f330bf8
Compare
|
Rebased on top of master. Note: the output from ragel makes a lot of trivial changes, like reordering of states. I am using ragel 6.10-1 from Ubuntu 18.04 repositories. |
ph
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
LGTM, it is a violation of the standard but at this point, the standard really relaxed :)
I've looked at the code and the test suite and everything is still correctly caught.
@candlerb Do you mind adding a changelog entry to https://github.com/elastic/beats/blob/master/CHANGELOG.asciidoc
This can go in the next 7.x, going to mark it as need backport.
candlerb
force-pushed
the
candlerb/13269
branch
from
f330bf8 to
4c4c1a3
Compare
|
Added entry to |
❕ Build Aborted
Expand to view the summary
Build stats
Log outputExpand to view the last 100 lines of log output
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
Hi! We're labeling this issue as |
jsoriano
removed
the
needs_backport
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Jul 31, 2020
elastic#13278) (cherry picked from commit 88c19e8)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 31, 2020
…ne-2.0 * upstream/master: New multiline mode in Filebeat: while_pattern (elastic#19662) Allow space or time sync character before timestamp on syslog messages (elastic#13278) Skip TestDockerStart (elastic#20361) Change licence of github.com/gorhill/cronexpr to Apache (elastic#20351)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13269