-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Libbeat] Log debug message if the Kibana dashboard can not be imported from the archive (#12211) #13387
[Libbeat] Log debug message if the Kibana dashboard can not be imported from the archive (#12211) #13387
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
…ed from the archive (#12211) There is a predefined combination of directory structure and setup.dashboards.beat property that has to be defined to successfully import dashboards to the Kibana.
jenkins test this |
@kvch Can you review this please? |
@dplavcic Could you please rebase the branch so we can merge your PR? |
Hi! We're labeling this issue as |
I didn't saw a notification about this until now. Anyways, thanks for merging this in. |
Fixes #12211
As described in #12211, depending on the value of setup.dashboards.beat there is a required directory structure for successful import of the Kibana dashboards from the archive file.
This PR adds additional path in case when no Kibana dashboards can be imported from the archive file, which logs debug message as shown below:
Implementation of point 2 from #12211 proposal.
There is a table in #12211 that contains test cases for this issue, but I currently don't know how to mock all necessary dependencies and implement unit tests for this without too much changes in libbeat/dashboards/importer.go.
I see that there are some integration tests for loading dashboards in libbeat/tests/system/test_dashboard.py so I'll check those out.