-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] config example for AD domain credential for MSSQL module #13594
Conversation
Forgot |
@geekpete are you sure you ran
|
@@ -30,6 +30,31 @@ The following Metricsets are already included: | |||
|
|||
`performance` Metricset fetches information from what's commonly known as https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-os-performance-counters-transact-sql?view=sql-server-2017[Performance Counters] in MSSQL. | |||
|
|||
=== Module-specific configuration notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to CI error, but you probably want a [float]
tag here before this section (otherwise this content will become a new topic).
jenkins test this again |
@sayden any opinions on this change? |
@geekpete I think the problem here is that your branch contains an old file that has invalid asciidoctor:
I don't see this problem in the master, so rebasing should fix it. |
49b79f8
to
4ff3479
Compare
@geekpete I hope you don't mind, but I went ahead and rebased this for you. Figured you'd want o move this forward. It should fix the CI so you can move this forward. |
Thank you @dedemorton ! |
Thanks for the work on getting this one finished, Team! Does this also mean we can close the related bug issues?
UPDATE: #12267 seems more related to a separate issue #14585 maybe we can also make it clear in the docs in a separate PR that this functionality isn't yet implemented. |
Provide an example of using credentials with a domain for the MSSQL Metricbeat module.
Potentially addresses #13006 and #12267
Backport to 7.x minor version branches