Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] config example for AD domain credential for MSSQL module #13594

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

geekpete
Copy link
Member

@geekpete geekpete commented Sep 11, 2019

Provide an example of using credentials with a domain for the MSSQL Metricbeat module.
Potentially addresses #13006 and #12267
Backport to 7.x minor version branches

@geekpete geekpete added docs Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. labels Sep 11, 2019
@geekpete geekpete requested a review from a team as a code owner September 11, 2019 01:26
@geekpete
Copy link
Member Author

Forgot make update again, got that done now after some wrangling with python and go versions in my environment.

@dedemorton
Copy link
Contributor

@geekpete are you sure you ran make update? After pulling down this PR and running make update, I see that a couple files are changed:

On branch pr_13594
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   x-pack/metricbeat/metricbeat.reference.yml
	modified:   x-pack/metricbeat/modules.d/mssql.yml.disabled

@@ -30,6 +30,31 @@ The following Metricsets are already included:

`performance` Metricset fetches information from what's commonly known as https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-os-performance-counters-transact-sql?view=sql-server-2017[Performance Counters] in MSSQL.

=== Module-specific configuration notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to CI error, but you probably want a [float] tag here before this section (otherwise this content will become a new topic).

@dedemorton
Copy link
Contributor

jenkins test this again

@exekias
Copy link
Contributor

exekias commented Nov 22, 2019

@sayden any opinions on this change?

@dedemorton
Copy link
Contributor

dedemorton commented Dec 2, 2019

@geekpete I think the problem here is that your branch contains an old file that has invalid asciidoctor:

07:40:29 INFO:build_docs:asciidoctor: ERROR: ../../libbeat/docs/shared-ssl-config.asciidoc: line 9: malformed preprocessor directive - text not permitted: endif::["{beatname_lc}"!="apm-server"]

I don't see this problem in the master, so rebasing should fix it.

@dedemorton dedemorton force-pushed the geekpete-patch-mssql-domain-credentials-2 branch from 49b79f8 to 4ff3479 Compare December 11, 2019 19:30
@dedemorton
Copy link
Contributor

dedemorton commented Dec 11, 2019

@geekpete I hope you don't mind, but I went ahead and rebased this for you. Figured you'd want o move this forward. It should fix the CI so you can move this forward.

@dedemorton
Copy link
Contributor

@sayden @exekias I've pushed some changes that should fix the docs CI. Can someone give this a technical review so we can get it merged? I feel badly that it's been open for so long.

@exekias
Copy link
Contributor

exekias commented Dec 12, 2019

Thank you @dedemorton !

@dedemorton dedemorton merged commit 4702e7a into master Dec 13, 2019
@dedemorton dedemorton deleted the geekpete-patch-mssql-domain-credentials-2 branch December 13, 2019 18:34
@geekpete
Copy link
Member Author

geekpete commented Dec 18, 2019

Thanks for the work on getting this one finished, Team!

Does this also mean we can close the related bug issues?

UPDATE: #12267 seems more related to a separate issue #14585 maybe we can also make it clear in the docs in a separate PR that this functionality isn't yet implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants