-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _source query in integration test. #13813
Conversation
waiting to see ci go green, thank you so much for fixing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the libbeat tests go green now. 🍏
Seems like two more places will need to be changed:
|
This is same location as before. But something else seems to have changed in ES as well. Looks like I'm going down a rabbid hole here. Just have some patience and CI will be green again :) |
I think it's failing because only the get APIs have been made typeless in Elasticsearch (elastic/elasticsearch#46931), but not the ingest APIs (still has |
@cwurm I think you are correct, after looking at the code seems we have a divergence between the ingest and the GET side. |
@cwurm Thanks, that seems to be the issue. I update the source query. Test runs through locally. Let's see what CI says. |
Source queries must be typeless most recently. Update query to
<index>/_source/<id>
in integration test.