Move light modules to OSS #14369
Merged
Move light modules to OSS #14369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ChrsMark
added
Team:Integrations
ChrsMark
force-pushed
the
move_lightmodules_to_oss
branch
from
ce390ea
to
7374b4c
Compare
|
jenkins, test this again |
ChrsMark
changed the title
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
move_lightmodules_to_oss
branch
from
7d24e02
to
9a1dda1
Compare
jsoriano
approved these changes
Nov 11, 2019
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
jsoriano
reviewed
Nov 11, 2019
x-pack/metricbeat/cmd/root.go
Outdated
| @@ -34,7 +33,7 @@ var RootCmd *cmd.BeatsRootCmd | |||
|
|
|||
| var ( | |||
| rootCreator = beater.Creator( | |||
| xpackbeater.WithLightModules(), | |||
| beater.WithLightModules(), | |||
| beater.WithModuleOptions( | |||
| module.WithMetricSetInfo(), | |||
| module.WithServiceName(), | |||
There was a problem hiding this comment.
Btw, could OSS metricbeat creators be reused here now?
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
approved these changes
Nov 11, 2019
|
ok to test |
ChrsMark
added
the
needs_backport
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Nov 12, 2019
(cherry picked from commit 4d1979b)
ChrsMark
added
v7.6.0
and removed
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Nov 12, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for light modules in OSS Metricbeat.
This is a blocker for developing the new metricsets of Kafka to collect JMx metrics. These metricsets will be built on top of Jolokia module as light metricsets.
The problem with this is that Kafka module is in OSS, but light modules are only supported in x-pack metricbeat, this makes it impossible to add this light metricset in a simple way in the OSS module.