Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #14498 to 7.x: Replace generate_imports python script with mage imports #14529

Merged
merged 4 commits into from
Nov 19, 2019

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 14, 2019

Cherry-pick of PR #14498 to 7.x branch. Original message:

This PR tries to refactor and unify the way we create include/list.go files. This came after we moved light modules to OSS and while trying to create a light module under OSS. In that case this module will be included in list.go file despite the fact that it has no .go files. This was not a problem when light modules where under x-pack because there the list.go was created by mage and the script was taking into consideration the existence of .go files in a module so as to decide if it should be included in list.go.

So far we had:

This PR refactors the OSS part so as to make use of the mage respective target likewise x-pack.

cc: @jsoriano , @exekias

@ChrsMark ChrsMark requested a review from a team as a code owner November 14, 2019 22:12
@ChrsMark ChrsMark added backport review Team:Integrations Label for the Integrations team labels Nov 14, 2019
@odacremolbap odacremolbap self-requested a review November 19, 2019 08:31
@ChrsMark ChrsMark merged commit 718d166 into elastic:7.x Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants