-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and extend logging of light modules load errors #14706
Fix and extend logging of light modules load errors #14706
Conversation
This is making many test to fail because they find errors in logs, I am adding |
what will happen to folks running tests outside docker? we need to think about that case too |
Logging-wise it would be the same. Regarding permissions, when running tests outside docker (and in systems with default umask != 0022 as most ubuntu distros) it is usual to require |
@jsoriano Seems like this PR is ready to go besides the conflict 😄 I saw this during triage party time. Could you take a look at this one again when you get a chance please? Thanks! |
@kaiyan-sheng good catch 😄 The original issue was solved in other way, but the fixes in logging may still be needed, I will take a look. |
Revisited, this would be ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a bug causing regular files in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Two things are solved here: * Errors were being logged with logp.Error that doesn't actually log anything, use a local logger and its Errorf method instead. * Log errors also when listing modules for string representation. This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors are logged if permissions are not correct. Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors. (cherry picked from commit 10da237)
Two things are solved here: * Errors were being logged with logp.Error that doesn't actually log anything, use a local logger and its Errorf method instead. * Log errors also when listing modules for string representation. This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors are logged if permissions are not correct. Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors. (cherry picked from commit 10da237)
Two things are solved here:
logp.Error
that doesn't actually log anything, use a local logger and itsErrorf
method instead.This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors like this one are logged if permissions are not correct:
Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors.