Make independent python virtualenvs in docker #14903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System tests running in docker are using the same virtual environment as the host. If version of python in the virtual environment is not available in the guest, it will use the default in the system, that is so far Python 2.
kvch
reviewed
Dec 3, 2019
kvch
approved these changes
Dec 3, 2019
|
As a slight optimization the VE setup by mage goes into build/ to avoid re-building it each time. https://github.com/elastic/beats/blob/master/dev-tools/mage/pytest.go#L235 I guess the Make portion doesn’t separate the VE’s into build/ve/{os} for us. |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
System tests running in docker are using the same virtual environment as the host. If version of python in the virtual environment is not available in the guest, it will use the default in the system, that is so far Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System tests running in docker are using the same virtual environment as
the host. If version of python in the virtual environment is not available
in the guest, it will use the default in the system, that is so far
Python 2.
Also install Python 3 in the dockers, and Pillow, that was needed on my
system when running locally.