remove Python 2 compatibility shims and casts #14989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
python2-cleanup
branch
from
2b3df90
to
9b4ed75
Compare
kvch
approved these changes
Dec 9, 2019
|
I think it's OK to merge it as is. I skimmed through the CI jobs, everything looks good. It is a good step forward, we can still regressions later if any is introduced by this PR. |
jsoriano
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Yeah, I agree, I think this can be merged. Thanks @beniwohli!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't want to support both Python 2 and Python 3 at the same time, a lot of compatibility shims and casts from iterators to lists can be avoided.
This PR is mostly based on regexing through #14798 and removing unnecessary changes. I tried to avoid introducing new changes.
Disclaimer: I wasn't able to run the test suite yet to make sure this doesn't introduce more errors than the parent PR. Hence the draft status.