Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15100 to 7.x: [metricbeat] [auditbeat] Add formatted index option to metricbeat / auditbeat modules #15130

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

faec
Copy link
Contributor

@faec faec commented Dec 16, 2019

Cherry-pick of PR #15100 to 7.x branch. Original message:

Resolves #14923 and #15065.

Adds an index formatted string option to all metricbeat modules that, when present, specifies the (elasticsearch) output index for events from that module.


// KeepNull determines whether published events will keep null values or omit them.
KeepNull bool `config:"keep_null"`

common.EventMetadata `config:",inline"` // Fields and tags to add to events.
}

func NewConnector(pipeline beat.Pipeline, c *common.Config, dynFields *common.MapStrPointer) (*Connector, error) {
func NewConnector(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function NewConnector should have comment or be unexported


// KeepNull determines whether published events will keep null values or omit them.
KeepNull bool `config:"keep_null"`

common.EventMetadata `config:",inline"` // Fields and tags to add to events.
}

func NewConnector(pipeline beat.Pipeline, c *common.Config, dynFields *common.MapStrPointer) (*Connector, error) {
func NewConnector(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function NewConnector should have comment or be unexported

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@faec faec merged commit a73fa46 into elastic:7.x Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants