Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Move HTTP calls to Logstash from New() to Fetch() (#15306) #15322

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.x:

@ycombinator ycombinator requested a review from a team as a code owner January 3, 2020 15:25
@ycombinator ycombinator requested a review from ph January 3, 2020 15:25
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* node_stats: move HTTP calls from New() to Fetch()

* node: move HTTP calls from New() to Fetch()

* Adding CHANGELOG entry

* Refactoring: extract common code into logstash package

* Unexporting getVersion
@ycombinator ycombinator merged commit d82bf59 into elastic:7.x Jan 6, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-15306 branch January 6, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants